Add support for gRPC binary metadata values #1791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-olszewski
force-pushed
the
olszewski/feat_grpc_bin_headers
branch
from
fa18a14 to
2235a4f
Compare
chris-olszewski
commented
Oct 3, 2025
| let Some(headers) = headers else { | ||
| return (None, None); | ||
| }; | ||
| let mut ascii_headers = HashMap::default(); |
There was a problem hiding this comment.
Possible optimization is to create the hashmap with the same capacity as the initial headers map. Only downside I could see would be if the headers were mostly binary.
There was a problem hiding this comment.
This is once per native client + on clientUpdateHeader. Neither of them should be called frequently enough to justify efforts on performance optimization IMO.
But if we'd indeed want to go there, I'd initiate both hashmaps at the capacity of the initial headers map, up to a certain upper limit (something like 128 or 256). That should optimize performance in all cases while providing a reasonable upper limit on how much memory we may allocate uselessly.
But honestly, I wouldn't mind that one.
chris-olszewski
force-pushed
the
olszewski/feat_grpc_bin_headers
branch
from
1b17bc4 to
def0d6c
Compare
chris-olszewski
force-pushed
the
olszewski/feat_grpc_bin_headers
branch
from
def0d6c to
b9ec854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added ability to send binary gRPC headers via
NativeConnection.Also added a test to verify that binary headers were accepted by
Connection.Why?
Make progress on temporalio/features#671
Checklist
Closes [Feature Request] Ensure gRPC binary metadata headers are supported #1778
How was this tested:
Added setting and sending of binary headers at both the client and call level for both native and the standard client connection.
Any docs updates needed?
I believe the type expansion from
stringtostring | Bufferis the only user facing change and that change should appear in the API reference.Each commit is reviewable on its own.